DEPRECATED.rikki icon indicating copy to clipboard operation
DEPRECATED.rikki copied to clipboard

[Ruby] Should not complain about shebang in test file

Open kotp opened this issue 8 years ago • 6 comments

When the test file is submitted in an iteration, Rikki complains about the #!/usr/bin/env ruby, and particularly about the #!. But this is not something Rikki should complain about in the test file.

kotp avatar Sep 28 '16 07:09 kotp

Rikki shouldn't be commenting on the test file at all, I think.

kytrinyx avatar Sep 28 '16 14:09 kytrinyx

Currently, Rikki's Ruby analyzer concatenates all the submission's source files so... it will technically check the test file if it's submitted in an iteration...

mhelmetag avatar Oct 20 '16 05:10 mhelmetag

Because we are free to submit the test file, surely even free to change the tests, and some of us encourage that kind of behavior, then Rikki should be free to comment on it.

When it becomes something that is directly submitted by the coder, it should become fair game. Indeed, when we write tests it should be "exemplary" as much as we can do so, and when it isn't, then it is good to have Rikki be able to point that out, lest someone thinks that it is code that is beyond comment.

kotp avatar Oct 20 '16 11:10 kotp

Sounds good. I think one approach to fix this then is to simply ignore shebang lines. Seems doable.

mhelmetag avatar Oct 20 '16 16:10 mhelmetag

ignore shebang lines

I explicitly have a rule for shebang lines, because people sometimes submit solutions with shebang lines, and these solutions are meant to be library-like things that other code can consume, not scripts to be run from the command-line.

kytrinyx avatar Nov 25 '16 20:11 kytrinyx

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 29 '17 20:04 stale[bot]