Exequiel Ceasar Navarrete
Exequiel Ceasar Navarrete
Would love to ask for some feedback on the PR @markostanimirovic and @brandonroberts especially on the issues that arised upon migrating to `vitest`. Thank you.
Hi @timdeschryver would love also your feedback here. Just a couple issues then I think it's good to go. Thank you.
> The failing type tests can be fixed by updating the timeout to `8_000` within the describe block (this will be passed down to each test case), similar to what's...
> The remaining CI errors are not caused by this PR => they should be resolved in #5044. There are 2 errors that's related to vitest uncaught exceptions. 1. I...
> We can publish the PR and I'll review it once more with a fresh head, I suppose it's good to be merged though. Hey @timdeschryver I removed the "draft"...
I just rebased the PR just moments ago based on the latest commits on the main branch. Did something change again or got merged?
> I just rebased the PR just moments ago based on the latest commits on the main branch. Did something change again or got merged? Checked. PR is still on...
I see one of the issues exceeded 8000ms. That's why something failed. https://github.com/ngrx/platform/actions/runs/20258235781/job/58164627027?pr=5036#step:8:1558