stats icon indicating copy to clipboard operation
stats copied to clipboard

feat: add option to show sensors with erroneous values

Open piernov opened this issue 2 years ago • 5 comments

Helpful when troubleshooting sensor issues where SMC reports an incorrect value because sensor is missing or has failed.

piernov avatar Jun 05 '22 12:06 piernov

Hi. Thanks for your PR. It's nice to open the issue before doing the PR. Why? Because we can discuss if this feature is needed for the app.

I understand the reason why you need that feature. But for most users it will be unclear what this option means. And I don't think that this feature is really needed in the app. If you want to debug your "errors" sensors, I can propose you use the SMC app: /Applications/Stats.app/Contents/Resources/smc list - to see a list of all sensors /Applications/Stats.app/Contents/Resources/smc fans - fans details

exelban avatar Jun 07 '22 15:06 exelban

I believe I wouldn't be the only one to use the software this way, this is only to be able to recommend it as a better alternative to HWMonitor for this use-case. Either way, even with the feature not eventually merged, people can easily see that the code already exists with a pull request.

piernov avatar Jun 07 '22 16:06 piernov

I think this feature is highly useful in the Mac repair community. So often we know we have a sensor issue due to high fans or bad performance. Being able to see which sensor isn't reading correctly quickly helps to zone in on the part or board component that is bad. With pre-2015 Macs, we were able to use MRI. Currently, we need to compare the reading between the device under test and a known good unit.

cbusillo avatar Jun 07 '22 18:06 cbusillo

Ok, I will check this PR. I will leave it for some time. If there will be more people who need this, I will merge that.

exelban avatar Jun 07 '22 18:06 exelban

I would find this feature extremely helpful for newer Macs. The current method of sensor hunting is arduous and time consuming. This would reduce my turnaround time on repairs significantly.

mrcbax avatar Jun 07 '22 19:06 mrcbax

I agree that this would be highly useful, but i also agree that it should not be the default, to ensure most users do not get confused. I suggest the PR be modified so that the feature is listed at the very bottom of the "Sensors" prefs page below the "Energy" section and entitled "Debug" with the single entry listed something like "Show data for sensors that provide erroneous data (WARNING: this should not be enabled except for diagnostics by technicians)." Thanks for submitting the PR !

fiveangle avatar Oct 18 '22 21:10 fiveangle

i suggest that the erroneous sensors should marked in a different color (red)

muescha avatar Nov 06 '22 18:11 muescha

Hi. There saw a long time when this issue was opened. There is no option to merge this PR now. But now sensors module have a Unknown sensors option. And I will add an option similar to this feature with time.

exelban avatar Jan 15 '23 21:01 exelban