exelban
Localize timeseries tooltips
I found the tooltips were not localized, so I formatted the date/time in the user's locale.
example: for locale en_US
i updated it.
do you know which version(s) it is an issue? i think this app could benefit nicely from monospaced digit system font being used more widely especially given how many digits we display. would it be worthwhile to add (not in this PR) some sort of polyfill like this
extension NSFont {
func safeMonospacedDigitSystemFont(... ){
if #available(macOS 13.0, *) {
return NSFont.monospacedDigitSystemFont(...)
} else {
return NSFont.SystemFont(...)
}
}
}
i can make an issue and/or give it a try if you want
no monospaced font. I was ready to merge that, but I have noticed that you make a lot of unnecessary changes. What is for? Im pretty sure that static width was for some reason since there was some problem with dynamic width.
It's a PR for localize timeseries tooltips, so please make sure it's only one change.
this is all becoming too much trouble, so i propose https://github.com/exelban/stats/pull/2689 instead
@exelban i have attempted to fix the jitter on this. the solution i came up with was to keep a max width of the localized date string. so it will converge to the longest value it encounters and hold onto it.