pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

Fixed 2 bugs: 1. read data was too short to successfully parse DNS qu…

Open Pierrow7675 opened this issue 1 year ago • 1 comments

…eries + 2. Receive events were not generated due to missing information in args_map

Pull Request Title

Pulsar IOT was not successfully generating DNS queries/answers information.

Implementation (Optional)

First the amount of data read is now corresponding to the data len - 1 in the packet (excl IP and UDP headers). Review is welcome on this point since that does not work if "len = output->data_len" (i.e. the exact size of the data in the packet) but with "len = output->data_len - 1".

For the data reception, destination address retrieval of the incoming packet is skipped. Actually we do not really care about this adress since it should be an adress of one of the network interface...

I have

  • [ ] run cargo fmt;
  • [ ] run cargo clippy;
  • [ ] run cargo testand all tests pass;
  • [ ] linked to the originating issue (if applicable).

Pierrow7675 avatar Mar 11 '24 13:03 Pierrow7675

before this change the args was NULL there was no output message to userspace. now what happens when args is NULL in userspace? there is a 1:1 mapping with a Rust struct, please check if it receives garbage

banditopazzo avatar Mar 21 '24 13:03 banditopazzo