[email protected] on myst-theme integration partly breaks DataFrame rendering for React Node

[GYHHAHA]

Describe the bug

This Bug 🐛 spent me a lot of time to find the reason. It's super wired when I saw the DataFrame is rendered twice: I thought it was caused by some regression from mystjs or myst-theme. However it's not. I finally got the idea from the common wrapper of these two block <div class="thebe-output" style="position: relative;"> ... </div> and then realized maybe it was caused by some components from thebe. After I changed thebe-core to 0.1.4, it works! Therefore this is caused by some unintended corner cases in #611 for text/html and text/plain render, which related to the fact that pandas DataFrame in the Jupyter format will both keep the original text/plain and the text/html for rendering. Hope these information will make the fix easier! @stevejpurves

Reproduce the bug

/

List your environment

No response

[welcome[bot]]

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada:

[rowanc1]

Thanks for the report @GYHHAHA! @stevejpurves is out on vacation this week, but when he gets back thebe and theme integration are top priorities, so we will certainly address this! Thanks also for your other PRs on the theme -- I will hopefully get to them this week!

[GYHHAHA]

Thanks for quick rely! @rowanc1 Besides, there is a dependency issue in myst-tools-theme. You can also take a look if available. Thanks!

[rowanc1]

I will keep an eye out for it (I don't think there is a specific issue tracking it?). I haven't found a good way to ensure that all of the packages work together reliably yet, and often run into installation problems when upgrading core packages. If you have suggestions or other specific issues you are running into there, happy to hear them to get a broader picture!

[GYHHAHA]

Yes, that's true. There are too many packages and they are distributed in several repos at the same time. It takes me a while to clarify the functions and relationship. Although the process was painful, fortunately I have figured out a lot. If there are some demands to document these js packages in the future, I'm willing to do the contribution.

[stevejpurves]

@GYHHAHA Thanks for the report! and I'll specifically check this case next - there were some changes to the PassiveCellRenderer to accommodate work on ipywidgets and ensuring smooth transition between stored and re-rendered outputs and it looks like this was introduced there.