thebe icon indicating copy to clipboard operation
thebe copied to clipboard

Visual indication a cell has been evaluated by Thebe

Open jackgerrits opened this issue 4 years ago • 6 comments

First of all thanks for this project and the work you do. Apologies if this is already supported.

Is your feature request related to a problem? Please describe.

At the moment when you evaluate a cell with Thebe in a notebook generated page there is no visual indication that the cell has in fact been evaluated, unless that cell produces output.

Describe the solution you'd like

Any visual indication of success would be helpful. The execution counter would be helpful to imply that all cells are evaluated in the same kernel.

Describe alternatives you've considered

I looked at https://sphinx-book-theme.readthedocs.io/en/latest/launch.html#live-code-cells-with-thebe and https://sphinx-thebe.readthedocs.io/en/latest/configure.html to see if there are any options to support this.

Additional context

sphinx-book-theme==0.1.0
sphinx-thebe==0.0.8

jackgerrits avatar Jun 22 '21 03:06 jackgerrits

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada:

welcome[bot] avatar Jun 22 '21 03:06 welcome[bot]

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada:

welcome[bot] avatar Feb 20 '22 16:02 welcome[bot]

Transferred this one over because I think this is where the fix will be. It might be helpful if the "loading wheel" that thebe uses ended with a green checkmark so that the reader knows that it has completed successfully. What do you think @stevejpurves ?

choldgraf avatar Feb 20 '22 16:02 choldgraf

yes, leaving the indicator as a green tick can be added. That would mark the completion of execution, rather than successful execution though? but we could probably add a green tick / red error depending on the contents of the output easily enough.

stevejpurves avatar Feb 21 '22 12:02 stevejpurves

Did this get completed? Using thebe with jupyterbook and would still love this functionality.

rcpeene avatar Nov 02 '22 20:11 rcpeene

It hasn't but we can add this in in the next 0.9.0-rc

stevejpurves avatar Nov 07 '22 12:11 stevejpurves