thebe
thebe copied to clipboard
Should kernelOptions.name be removed from docs?
In the readme instructions we mention kernelOptions.name but I can't tell whether it's used at all, I believe the kernelOptions dict is used by JupyterLab and it doesn't seem like .name is used anywhere, perhaps we should remove it?
kernalOptions.name is passed in as the name of a session connection. The comments of @jupyterlab/services(the package thebelab uses) shows:
#### Notes
The `path` and `type` session model parameters are required. The `name`
parameter is not technically required, but is often assumed to be nonempty,
so we require it too.
As it suggests keeping the name parameter, I think keeping it would be a good idea. However, using python3 as a value might be confusing. I suggest changing it to something related to a session name to be clear.