sphinx-panels icon indicating copy to clipboard operation
sphinx-panels copied to clipboard

No i18n support for link-button directive

Open jpmckinney opened this issue 4 years ago • 3 comments

The :text: option is not passed through gettext. It is not extracted by Sphinx's gettext builder.

I think the "easy" solution is to put the text in the body of the directive, like all other directives.

I guess this would require a major/minor version change, unless you support both :text: options and directive bodies at once.

jpmckinney avatar Jul 31 '21 21:07 jpmckinney

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada:

welcome[bot] avatar Jul 31 '21 21:07 welcome[bot]

Heya, as mentioned in #67, this package is essentially being deprecated for sphinx-design, and that is indeed exactly how it works there: https://sphinx-design.readthedocs.io/en/latest/badges_buttons.html#buttons

chrisjsewell avatar Jul 31 '21 22:07 chrisjsewell

Awesome!

jpmckinney avatar Aug 01 '21 13:08 jpmckinney