sphinx-design icon indicating copy to clipboard operation
sphinx-design copied to clipboard

i18n: Spurious (and translatable) alt-text added to cards

Open jpmckinney opened this issue 2 years ago • 1 comments

Describe the bug

Due to lines like:

https://github.com/executablebooks/sphinx-design/blob/42077cf08756019db3936fbd9a66d68f6ce6d23d/sphinx_design/cards.py#L117

My POT file contains, in this case:

msgid "card-img-top"
msgstr ""

Reproduce the bug

Run sphinx-build -b gettext docs _build (or whatever paths are appropriate) while using this package and using the img-background, img-top or img-bottom options.

List your environment

Not environment dependent.

jpmckinney avatar Dec 08 '22 04:12 jpmckinney

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada:

welcome[bot] avatar Dec 08 '22 04:12 welcome[bot]

I believe this was closed in #114

chrisjsewell avatar May 22 '24 16:05 chrisjsewell