sphinx-book-theme icon indicating copy to clipboard operation
sphinx-book-theme copied to clipboard

Tables expand to width of display adding lots of white space between columns

Open bradbell opened this issue 1 year ago • 4 comments

Describe the bug

When I create a table, sphinx-book-theme always expands it to take of the full width of the display, unlike other sphinx themes; e.g., sphinx-rtd-theme and furo. This can result in lots of white space between columns (when the browser window is wide).

In the example below, in the file test_sphinx.git/source/conf.py, if you replace sphinx_book_theme by sphinx_rtd_theme, the table width will contract and not include a huge amount of white space before and after the second column.

Reproduce the bug

git clone https://github.com/bradbell/test_sphinx.git test_sphinx.git
cd test_sphinx.git
mkdir source/_static
git checkout sphinx_book_theme -b temp
make html
firefox build/html/index.html &

List your environment

test_sphinx.git>uname -a Linux fedora 6.6.6-200.fc39.x86_64 #1 SMP PREEMPT_DYNAMIC Mon Dec 11 17:29:08 UTC 2023 x86_64 GNU/Linux

test_sphinx.git>python --version Python 3.12.0

test_sphinx.git>dnf info sphinx | grep '^Version' Version : 2.2.11

test_sphinx.git>pip list | grep sphinx-book-theme sphinx-book-theme 1.0.1

bradbell avatar Jan 05 '24 14:01 bradbell

Hi, I just came across the same problem, this should be able to be solved by adding the wrapper class that e.g furo uses. I hope it will be implemented! https://github.com/pradyunsg/furo/blob/01887051504bbec32e241af9cebcf5cd10f656d1/src/furo/init.py#L37 The table-wrapper class then needs atleast the following css overflow-x: auto;

Theowyn avatar Feb 16 '24 09:02 Theowyn

I use furo instead of sphinx-book-theme for my six projects on readthedocs because of this problem; e.g., https://xrst.readthedocs.io/latest/

Are there any plans to fix this ?

bradbell avatar Mar 05 '24 13:03 bradbell

@Theowyn Can you please make a pull request for the fix?

bosd avatar Aug 28 '24 18:08 bosd

@Theowyn Can you please make a pull request for the fix?

hi, I have not fixed the issue myself. I have only created a workaround by adding the css class via javascript which needs to be assigned.

Edit: I have updated to 1.1.3 and it seems it is no longer an issue. my tables are properly wrapped in class pst-scrollable-table-container

Theowyn avatar Dec 09 '24 10:12 Theowyn