sphinx-book-theme icon indicating copy to clipboard operation
sphinx-book-theme copied to clipboard

Bump the version of pytest for compatibility with python 3.10

Open ZedThree opened this issue 3 years ago • 1 comments
trafficstars

Pytest 6.2.5 is the first version that supports python 3.10: https://pytest.org/en/latest/changelog.html#pytest-6-2-5-2021-08-29

ZedThree avatar Oct 07 '22 14:10 ZedThree

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

welcome[bot] avatar Oct 07 '22 14:10 welcome[bot]

Hi @ZedThree, I would suggest bump the version of pytest more, and pytest-cov as well. Like here: https://github.com/executablebooks/MyST-NB/blob/master/pyproject.toml#L103

AakashGfude avatar Oct 19 '22 10:10 AakashGfude

Should I bump myst-nb version at the same time?

ZedThree avatar Oct 19 '22 10:10 ZedThree

@ZedThree, we will do that in a separate PR. It needs some additional testing.

AakashGfude avatar Oct 19 '22 10:10 AakashGfude

Congrats on your first merged pull request in this project! :tada: congrats
Thank you for contributing, we are very proud of you! :heart:

welcome[bot] avatar Oct 19 '22 11:10 welcome[bot]