sphinx-book-theme icon indicating copy to clipboard operation
sphinx-book-theme copied to clipboard

Trying to support alternative git servers

Open tschm opened this issue 3 years ago • 2 comments

Generalize the _split_repo_url. Still works as exactly as before for GitHub urls but doesn't fall over for GitLab.

tschm avatar Sep 19 '22 04:09 tschm

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

welcome[bot] avatar Sep 19 '22 04:09 welcome[bot]

I was hoping I could point to our internal Jupyter-Hub server. There is no chance I can rely on Binder.

tschm avatar Oct 01 '22 04:10 tschm

Gotcha - can you confirm that this actually works for GitLab or other repositories? Could you also add some test or example in the documentation that shows a functioning GitLab link (at least with mybinder.org, I know it's hard to test against a JupyterHub)

choldgraf avatar Nov 09 '22 10:11 choldgraf