sphinx-book-theme
sphinx-book-theme copied to clipboard
executablebooks
[ENH, DOC] Allow setting the `navbar_max_depth` and `collapse_navbar`
I was not able to figure out how to actually build the docs I wrote for this. I have manually tested that the two new settings work for me.
As this is just exposing functionality from pydata-sphinx-theme, I am not sure it needs tests written?
fixes #603
Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:
![welcome[bot] avatar](https://avatars.githubusercontent.com/in/4141?v=4 "Published by a pub.dev verified publisher"){kind=small}
@gilbertbw I tried pushing to your branch to fix the merge conflict but got access denied - can you run a merge commit from master and then we can merge?
Sorry, I missed the notifications about this. I have merged in master as requested.
Hi, @choldgraf can I help somehow getting this merged? We'd like to use this option for the ROCm documentation (https://github.com/RadeonOpenCompute/rocm-docs-core/issues/413).
I rebased the branch to current master, its available here: https://github.com/StreamHPC/sphinx-book-theme/tree/gbw-additional-theme-customisation. Should I make a PR?
Congrats on your first merged pull request in this project! :tada:
Thank you for contributing, we are very proud of you! :heart:
The change and the tests seem OK, though might fail since we haven't rebased on master. Since this one has been waiting a bit I'm just gonna merge and we can see how it impacts the tests and do a spot-fix if necessary. That's easier than opening a whole new PR