sphinx-book-theme icon indicating copy to clipboard operation
sphinx-book-theme copied to clipboard

Set "readthedocs" ad placement explicitly

Open choldgraf opened this issue 4 years ago • 5 comments

Right now, if people host their documentation on readthedocs, it will automatically put an advertisement at the bottom of the page:

image

It's not too obtrusive, though it clashes a bit with our CSS and overlaps with some elements.

I believe that we can include some HTML that will instead tell RTD to put the add there instead of at the bottom, and so we can control how it looks etc a bit better. What do folks think about that?

I believe we need to add: https://github.com/pradyunsg/furo/blob/main/src/furo/theme/furo/sidebar/ethical-ads.html?rgh-link-date=2021-03-20T19%3A15%3A02Z

choldgraf avatar Aug 09 '20 15:08 choldgraf

While your mentioning RTD, I would also link https://github.com/pandas-dev/pydata-sphinx-theme/issues/194

chrisjsewell avatar Aug 09 '20 15:08 chrisjsewell

@chrisjsewell I've actually open an issue for this very purpose: https://github.com/pydata/pydata-sphinx-theme/issues/345

I'm just jumping here, Ware there any evolution on this matter since August ?

12rambau avatar Mar 22 '21 14:03 12rambau

@12rambau nope - we'd still like it to happen - if anyone would like to give a shot at a PR I am happy to review!

choldgraf avatar Mar 22 '21 14:03 choldgraf

I was looking on how you handling the ad placement in RDT and Google lead me here but I think I'm actually off-topic

if anyone would like to give a shot at a PR I am happy to review!

If only, I was good enough in HTML/CSS 😄

12rambau avatar Mar 22 '21 14:03 12rambau

I think I found a good pattern here: https://github.com/pradyunsg/furo/blob/main/src/furo/theme/furo/sidebar/ethical-ads.html?rgh-link-date=2021-03-20T19%3A15%3A02Z

updated the top comment

choldgraf avatar Mar 22 '21 14:03 choldgraf