jupyter-book icon indicating copy to clipboard operation
jupyter-book copied to clipboard

Improve custom admonitions documentation

Open leodrivera opened this issue 2 years ago • 3 comments

As commented in #1345, it's the pull request for the correction of the raised points

leodrivera avatar Jul 13 '22 22:07 leodrivera

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

welcome[bot] avatar Jul 13 '22 22:07 welcome[bot]

Codecov Report

Base: 91.37% // Head: 91.37% // No change to project coverage :thumbsup:

Coverage data is based on head (abc8ffe) compared to base (4f0944f). Patch has no changes to coverable lines.

:exclamation: Current head abc8ffe differs from pull request most recent head 3541039. Consider uploading reports for the commit 3541039 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1777   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files           7        7           
  Lines         684      684           
=======================================
  Hits          625      625           
  Misses         59       59           
Flag Coverage Δ
pytests 91.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 13 '22 22:07 codecov[bot]

Hello @brownsarahm

Do you know who we can ping to approve this PR? Thanks in advance

leodrivera avatar Aug 09 '22 21:08 leodrivera

Congrats on your first merged pull request in this project! :tada: congrats
Thank you for contributing, we are very proud of you! :heart:

welcome[bot] avatar Nov 15 '22 09:11 welcome[bot]