jupyter-book icon indicating copy to clipboard operation
jupyter-book copied to clipboard

Change syntax highlighting example

Open fmaussion opened this issue 3 years ago • 2 comments

Closes https://github.com/executablebooks/jupyter-book/issues/1668

fmaussion avatar Jun 12 '22 09:06 fmaussion

Codecov Report

Merging #1752 (0b2d955) into master (9128148) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1752   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files           7        7           
  Lines         684      684           
=======================================
  Hits          625      625           
  Misses         59       59           
Flag Coverage Δ
pytests 91.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9128148...0b2d955. Read the comment docs.

codecov[bot] avatar Jun 12 '22 09:06 codecov[bot]

Actually, I think there is probably a nicer way of solving this. We should add highlight_language: none around here and see if this solves the problem:

https://github.com/executablebooks/jupyter-book/blob/9128148a088a23df4cc4eaa4271e259207cec4e9/jupyter_book/config.py#L37

This would changes the default so that no language given would default to "no highlighting", which I think is what most people would expect.

choldgraf avatar Jun 12 '22 10:06 choldgraf

Just gonna merge this one in and we can improve broader syntax defaults later

choldgraf avatar Aug 19 '22 11:08 choldgraf