tailwindcss-stimulus-components icon indicating copy to clipboard operation
tailwindcss-stimulus-components copied to clipboard

Published 20 hours ago • verified publisher icon excid3

"slideover#_hide" is typo?

Open philipithomas opened this issue 3 years ago • 4 comments

Hey Chris! In the ReadMe you reference slideover#_hide in the example code, but the demo never uses the underscore - only slideover#hide. Is this an error, or does the underscore have some undocumented functionality?

PS this library is great - thanks!

philipithomas avatar Nov 05 '21 01:11 philipithomas

Yeah I think that should be slideover#hide as the underscore version is more the internal API that's used. We don't use any underscore methods in the example page: https://github.com/excid3/tailwindcss-stimulus-components/blob/master/docs/index.html

excid3 avatar Nov 05 '21 13:11 excid3

Ok - I'm seeing weird behavior in my app when I remove the underscores: https://www.loom.com/share/4a9ff7a3b98949c6ad1adf71d49e9b71

philipithomas avatar Nov 05 '21 22:11 philipithomas

The demo is working as expected. Its action is slideover#toggle. So, it should be updated as slideover#toggle, instead of slideover#hide

ozovalihasan avatar Nov 07 '21 11:11 ozovalihasan

In the javascript file, there's example html at the top of the file. It uses _hide and _show. Would be nice if that was updated. Not sure if this is closeable yet.

Merovex avatar Jun 23 '22 10:06 Merovex