noticed icon indicating copy to clipboard operation
noticed copied to clipboard

Published 20 hours ago • verified publisher icon excid3

Disable logging of sensitive params

Open henryaj opened this issue 3 years ago • 3 comments

Is there any way to disable logging of sensitive params?

Whenever noticed enqueues a job, I can see all the params of that job are printed to STDOUT. It looks like ActiveJob supports selectively disabling these by setting self.log_arguments = false on the job; is there a similar feature here? Thanks!

henryaj avatar Jan 17 '22 15:01 henryaj

Nothing currently, but PRs are welcome. The trouble is we save the params in the database so I'm not sure it's really solvable unless you encrypt them.

excid3 avatar Jan 17 '22 16:01 excid3

Ah, I meant "logging" specifically in terms of "writing sensitive data to logs" rather than the storing of said data, which I'm fine with.

Great, might look into a PR!

henryaj avatar Jan 17 '22 17:01 henryaj

We don't do any custom logging. Just hand things off to the database an ActiveJob. So I'd be curious to see which part is writing to the logs then if you've turned them off for ActiveJob. Probably the ActiveRecord logs would be the only other thing?

excid3 avatar Jan 17 '22 17:01 excid3