beatoraja icon indicating copy to clipboard operation
beatoraja copied to clipboard

Minimum input duration(ms) should not affect turntable inputs

Open nyannurs opened this issue 6 years ago • 1 comments

Setting the minimum input duration to a higher value will also affect analog turntable inputs. There is no need for this, since turntable inputs rarely, or never double fire. Inputs from an analog turntable should not be handled in the same way inputs from a microswitch are, as those are more prone to doublefiring or misfiring in later stages of the microswitch's life. This issue is not present in an analog turntable until way later into its lifetime, making the restriction of the turntable's inputs through the minimum input duration redundant.

The settings should be split: there should be a minimum input duration setting for keys, and a minimum input duration setting for the turntable.

nyannurs avatar Dec 24 '19 00:12 nyannurs

There are two ways to solve this.

Option 1. Split "Minimum input duration(ms)" setting for keys and turntable

  • Two settings: "Minimum key input duration(ms)" and "Minimum turntable input duration(ms)"
  • This will apply for all input modes
    • Keyboard
    • MIDI
    • BM (LR2 scratch)
    • BM (analog scratch ver 1)
    • BM (analog scratch ver 2)
  • Issue: this means more settings for the player to set, may be confusing for player.
  • keyboard players may want both settings to be the same (because keys + scratch use the same keyboard)

Option 2. Disable minimum input duration for BM (analog scratch ver 2) turntable only

  • All other input modes will not be affected.
  • No new setting will be introduced.

wcko87 avatar Dec 28 '19 21:12 wcko87