EWZRecaptchaBundle
EWZRecaptchaBundle copied to clipboard
excelwebzone
Feature symfony7 update
@snipershady please run the check and fix the issues before I can merge it. Thanks.
@snipershady please run the check and fix the issues before I can merge it. Thanks.
Michael I've fixed, now all PHPunit tests are succesfully completed
OK (23 tests, 99 assertions)
Nope, still not passing.. https://github.com/excelwebzone/EWZRecaptchaBundle/actions/runs/7359000381/job/20033164385?pr=306
Oo I forgot what php < 7.3 does not support strict type declartion for attributes...
let me fix it again with legacy compatibility
Still not working.. https://github.com/excelwebzone/EWZRecaptchaBundle/actions/runs/7359071392/job/20033299482?pr=306
Still not working.. https://github.com/excelwebzone/EWZRecaptchaBundle/actions/runs/7359071392/job/20033299482?pr=306
because we cannot run test with Symfony 7.0 on PHP < 8.2
I think we should create a new branch of the package with PHP 8.2 strict compatibility, if we want to run this bundle on symfony 7.
composer.json of symfony
"require": { "php": ">=8.2", "ext-ctype": "*", "ext-iconv": "*", ... ... }
what do you think about?
I've updated the arraylist of version and tests for CI
:crossed_fingers:
Sorry. Still not working.. Right now I don't have a lot of time to spend on this.. but once I'd I will try to fix your PR
Sorry. Still not working.. Right now I don't have a lot of time to spend on this.. but once I'd I will try to fix your PR
I've rollback to some backward legacy compatibility for the deprecated PHP version let's figure it out if this is the final shot
Still not working. I don't think you can convert to PHP7 unless you remove all previous versions. Sorry :-(
Still not working. I don't think you can convert to PHP7 unless you remove all previous versions. Sorry :-(
it is on you, I do not want to change compatibilty of the package with legacy versions, but it seams to be necessary. I've done a fork only with current version of PHP and Symfony to upgrade my symfony softwares, and it works fine. If you accept to change the backward compatibility with ancient php version and ancient symfony version, I will be glad to prepare a new PR.
