EWZRecaptchaBundle icon indicating copy to clipboard operation
EWZRecaptchaBundle copied to clipboard

Published 20 hours ago • verified publisher icon excelwebzone

patch version update to 1.5.19 breaks BC

Open digibeuk opened this issue 5 years ago • 1 comments

I noticed an update to 1.5.19 from 1.5.18 breaks BC because of the signature change in \EWZ\Bundle\RecaptchaBundle\Validator\Constraints\IsTrueValidator

it was introduced here : https://github.com/excelwebzone/EWZRecaptchaBundle/commit/1b3c8cae3737ae62f6187902716237173de4097e#diff-868e2d307410dbab0dd4664637452171

this does not comply with semantic versioning practices, any way you could reverse the change and/or add a nullable property to the constructor to support both situations?

digibeuk avatar Jul 24 '20 06:07 digibeuk

You are more then welcome to create a PR to fix this issue..

excelwebzone avatar Jul 24 '20 12:07 excelwebzone