excalidraw-libraries icon indicating copy to clipboard operation
excalidraw-libraries copied to clipboard

feat: new library Timeline

Open excalibot opened this issue 2 years ago • 8 comments

Set of items to create timelines for quick planning and tracking of projects, tasks, competing events, etc.

Submitted by @jgodoy

Items: Example timeline, Base timeline, Markers - Up, Markers - Down, Callouts - Up, Callouts - Down, Circles, Time blocks

Installation link

excalibot avatar Sep 23 '22 19:09 excalibot

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
excalidraw-libraries ✅ Ready (Inspect) Visit Preview Sep 23, 2022 at 7:35PM (UTC)

vercel[bot] avatar Sep 23 '22 19:09 vercel[bot]

Hi @jgodoy, and thanks for the lib!

Two questions:

  1. there are connecting lines between individual points, and then there's an extra line underneath. Is that by design?
  2. similarly, is it by design that the connecting lines are separate into two segments?

lib-q1

dwelle avatar Oct 02 '22 16:10 dwelle

Hello.

The line below the is intentional. It could be split into two smaller ones so the three timeline begins with a line instead on the circles.

As for the circles, in my tests this allowed for better positioning for larger timelines. It can be changed for smaller ones, though, but I opted to keep it a single thing.

If those are issues, I can change them.

Cheers, Jorge

Em dom., 2 de out. de 2022 13:06, David Luzar @.***> escreveu:

Hi @jgodoy https://github.com/jgodoy, and thanks for the lib!

Two questions:

  1. there are connecting lines between individual points, and then there's an extra line underneath. Is that by design?
  2. similarly, is it by design that the connecting lines are separate into two segments?

[image: lib-q1] https://user-images.githubusercontent.com/5153846/193464093-be5735c4-b13d-41e2-bdd9-f81a74173df7.gif

— Reply to this email directly, view it on GitHub https://github.com/excalidraw/excalidraw-libraries/pull/637#issuecomment-1264677348, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABJSPK5PEQ755MNFQYVSGTWBGXJDANCNFSM6AAAAAAQUICPF4 . You are receiving this because you were mentioned.Message ID: @.***>

jgodoy avatar Oct 02 '22 16:10 jgodoy

The line below the is intentional. It could be split into two smaller ones so the three timeline begins with a line instead on the circles.

Yes, I was thinking if the ideas is for the timeline to begin & end with a line, those line segments could be added at the start & end instead of making the timeline into a "double line".

As for the circles, in my tests this allowed for better positioning for larger timelines. It can be changed for smaller ones, though, but I opted to keep it a single thing.

Not sure I understand. What I meant is why the line segments between the circles are composed of 3-point lines which result in them being visually "broken" into two segments. If that doesn't serve a function, then let's remove the middle points of each segment?

dwelle avatar Oct 02 '22 17:10 dwelle

David, good morning.

  1. 3-point items: this is the default when using an arrow to connect the objects. I've kept that as it allows the connection moving together with the "circle" if the user repositions the timeline. The line won't be tied to the object and also shows up as 3 points.

  2. I've changed the line below the timeline and added arrows to each end, so that it also attaches to the start / end circle of the timeline.

I've downloaded the library again and I'm looking into how to send it back with the corrections. If you have any procedure, I'd appreciate it. In the meantime, I'm attaching it here in case there is a need for extra changes on the example and the timeline object.

Thanks in advance, Jorge.

-- Jorge Godoy @.***>

Em seg., 3 de out. de 2022 às 09:22, Jorge Godoy @.***> escreveu:

Good morning.

I'll check how to update the submission and make the changes we discussed during the weekend.

Thanks for the review. It was very productive and I hope it will improve the usage of these objects to other people.

-- Jorge Godoy @.***>

Em dom., 2 de out. de 2022 às 18:08, Jorge Godoy @.***> escreveu:

Hi again.

Sorry for the quick drawing. Only had mobile access for the day.

For more complex timelines, one may add extra space or make a different format (such as the example below) and the intermediate connectors (3-point) help with this kind of change. Again, open to suggestions and changes. I've been using this version for a while now and found it useful as it was.

[image: image.png]

-- Jorge Godoy @.***>

Em dom., 2 de out. de 2022 às 14:28, David Luzar < @.***> escreveu:

The line below the is intentional. It could be split into two smaller ones so the three timeline begins with a line instead on the circles.

Yes, I was thinking if the ideas is for the timeline to begin & end with a line, those line segments could be added at the start & end instead of making the timeline into a "double line".

As for the circles, in my tests this allowed for better positioning for larger timelines. It can be changed for smaller ones, though, but I opted to keep it a single thing.

Not sure I understand. What I meant is why the line segments between the circles are composed of 3-point lines which result in them being visually "broken" into two segments. If that doesn't serve a function, then let's remove the middle points of each segment?

— Reply to this email directly, view it on GitHub https://github.com/excalidraw/excalidraw-libraries/pull/637#issuecomment-1264693934, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABJSPLWQDHH4CGY2TR6VHLWBHA5FANCNFSM6AAAAAAQUICPF4 . You are receiving this because you were mentioned.Message ID: @.***>

jgodoy avatar Oct 03 '22 12:10 jgodoy

Hi again.

Sorry for the quick drawing. Only had mobile access for the day.

For more complex timelines, one may add extra space or make a different format (such as the example below) and the intermediate connectors (3-point) help with this kind of change. Again, open to suggestions and changes. I've been using this version for a while now and found it useful as it was.

[image: image.png]

-- Jorge Godoy @.***>

Em dom., 2 de out. de 2022 às 14:28, David Luzar @.***> escreveu:

The line below the is intentional. It could be split into two smaller ones so the three timeline begins with a line instead on the circles.

Yes, I was thinking if the ideas is for the timeline to begin & end with a line, those line segments could be added at the start & end instead of making the timeline into a "double line".

As for the circles, in my tests this allowed for better positioning for larger timelines. It can be changed for smaller ones, though, but I opted to keep it a single thing.

Not sure I understand. What I meant is why the line segments between the circles are composed of 3-point lines which result in them being visually "broken" into two segments. If that doesn't serve a function, then let's remove the middle points of each segment?

— Reply to this email directly, view it on GitHub https://github.com/excalidraw/excalidraw-libraries/pull/637#issuecomment-1264693934, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABJSPLWQDHH4CGY2TR6VHLWBHA5FANCNFSM6AAAAAAQUICPF4 . You are receiving this because you were mentioned.Message ID: @.***>

jgodoy avatar Oct 11 '22 07:10 jgodoy

Good morning.

I'll check how to update the submission and make the changes we discussed during the weekend.

Thanks for the review. It was very productive and I hope it will improve the usage of these objects to other people.

-- Jorge Godoy @.***>

Em dom., 2 de out. de 2022 às 18:08, Jorge Godoy @.***> escreveu:

Hi again.

Sorry for the quick drawing. Only had mobile access for the day.

For more complex timelines, one may add extra space or make a different format (such as the example below) and the intermediate connectors (3-point) help with this kind of change. Again, open to suggestions and changes. I've been using this version for a while now and found it useful as it was.

[image: image.png]

-- Jorge Godoy @.***>

Em dom., 2 de out. de 2022 às 14:28, David Luzar @.***> escreveu:

The line below the is intentional. It could be split into two smaller ones so the three timeline begins with a line instead on the circles.

Yes, I was thinking if the ideas is for the timeline to begin & end with a line, those line segments could be added at the start & end instead of making the timeline into a "double line".

As for the circles, in my tests this allowed for better positioning for larger timelines. It can be changed for smaller ones, though, but I opted to keep it a single thing.

Not sure I understand. What I meant is why the line segments between the circles are composed of 3-point lines which result in them being visually "broken" into two segments. If that doesn't serve a function, then let's remove the middle points of each segment?

— Reply to this email directly, view it on GitHub https://github.com/excalidraw/excalidraw-libraries/pull/637#issuecomment-1264693934, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABJSPLWQDHH4CGY2TR6VHLWBHA5FANCNFSM6AAAAAAQUICPF4 . You are receiving this because you were mentioned.Message ID: @.***>

jgodoy avatar Oct 11 '22 09:10 jgodoy

Hi @jgodoy — sorry for the late response, got stuck elsewhere!

You can simply re-submit all of the (corrected) items again, and we'll close this one.

dwelle avatar Oct 13 '22 12:10 dwelle