puppet-tp icon indicating copy to clipboard operation
puppet-tp copied to clipboard

tp::install uses deprecated options_hash/settings_hash

Open zajdee opened this issue 7 months ago • 1 comments

Hi, thank you for your work on puppet-tp.

It seems that even the latest install.pp calls tp::conf with settings_hash and options_hash on multiple places, for example: https://github.com/example42/puppet-tp/blob/89524ae96062d36572a2eb1c33fc97b28920ab3b/manifests/install.pp#L431-L437

However these two functions are now deprecated: https://github.com/example42/puppet-tp/blob/89524ae96062d36572a2eb1c33fc97b28920ab3b/manifests/conf.pp#L258-L263

The call to deprecation() causes Puppet to fail when in strict mode.

zajdee avatar May 14 '25 22:05 zajdee

@zajdee Thanks for the notice, can you give a look at the above MR to confirm if it fixes your issues?

alvagante avatar May 20 '25 22:05 alvagante