puppet-php
puppet-php copied to clipboard
example42
Fix for issues with ini file on Ubuntu
This is a first pass work around. I'm new to Puppet and really don't know what I'm doing, so please give feedback about what I missed. This is really a case of "this [seems to] work for me".
-Thanks
@loren-osborn
Well congratulations for the code, but to be honest it looks a bit too much: to manage particular cases it's enough to set a custom value for the config_file path, so I assume that can be enough for the not common cases.
I'm fine with manual configuration parameters, but the real problem I think I was having was that $php:: web_config_dir and $php:: config_dir weren't independent of each other, and weren't externally settable. Maybe drop the custom fact for a settable parameter, and go with the rest of the PR? (The custom fact turned out to only work AFTER php got installed after all, anyway.) Can you suggest a better strategy?
Ok, now I understand... and yes, I'd prefer an approach based on sane defaults which can be overridden by users.
Does this naive approach sound reasonable for you? https://github.com/example42/puppet-php/commit/70a89b0884024b94bb4f74850ac83b5f7a04fca5 Surely less sophisticated than the solution you propose but definitively simpler, and possible less error proof and maintainable.
I'm still rather green on Puppet's syntax, and don't really have time to test this now, but it looks good in theory.
-Thanks