puppet-php icon indicating copy to clipboard operation
puppet-php copied to clipboard

php package name required by module installation

Open apengue opened this issue 9 years ago • 1 comments

in module.pp, on line 91 (last before closing parenthesis) there is:

require => Package['php'],

it should be

require => Package[$php::package],

otherwise, installing another php package (php55, php56 from another repo (epel/remi as example for Fedora/Centos/RHEL) will cause the module part to be ignored as the require clause will be missed.


update: same in init.php: 251: package { "${php::package}": 263: require => Package["${php::package}"],

apengue avatar Aug 18 '15 14:08 apengue

Good point, would you mind to submit a PR with the fixes?

alvagante avatar Aug 20 '15 10:08 alvagante