example42
added support for rhel route6 files to mroute.pp
This PR is a fixup for the issue https://github.com/example42/puppet-network/issues/261 I opened 2 months ago.
Eventually it creates a route6-$name file under RHEL Systems when mroute is used so that IPv6 routes can be used.
Therefor the $routes hash first is splitted with $hash.reduce and Stdlib::IP::Address Regex matches into a hash containing only v4 and one only containing v6 routes. Each file has its own default tempalte which uses the the associated variable and the files are only created if a route exists.
Additionally a parameter $route6_tempalte is introduced to overwrite the template file in the same way as it is possilbe for $route_down_template
The change should not interfere with Debian/SUSE Support since it's not touching their templates/variables.
puppet-lint --no-autoloader_layout-check mroute.pp returns no error.
Thanks for the PR, the module is supposed to be Puppet 3 compatible, so the reduce function fails on old Puppet versions (see Travis checks). As now I've to keep this MR on hold, until we upgrade the major release of the module and make it Puppet >= 4 only compatible.
As now I've to keep this MR on hold, until we upgrade the major release of the module and make it Puppet >= 4 only compatible.
Can you say when you'll drop Puppet 3 support?
@chrisongthb I've version 4 ready for some time in https://github.com/example42/puppet-network/tree/version4, but have to do more tests and resync it with latest version of legacy defines, which will be maininted for backwards compatibility. Release due maybe during xmas break, maybe later.