ewolfe

Results 30 comments of ewolfe

Should also look into https://facebook.github.io/jest/docs/en/mock-functions.html

In retrospect, I want to take a different approach. At a high level, PRLint is not a pure function `f(x) = y`. In fact, the consumer of PRLint (GitHub's webhooks)...

More resources: - https://hackernoon.com/api-testing-with-jest-d1ab74005c0a - https://sinonjs.org/releases/v2.1.0/fake-xhr-and-server/#fake-server - https://codeutopia.net/blog/2015/01/30/how-to-unit-test-nodejs-http-requests/ - https://mherman.org/blog/stubbing-http-requests-with-sinon/ - https://www.npmjs.com/package/request-spy

`expect(body).toMatchObject(issueCreatedBody)` via https://probot.github.io/docs/testing/ seems like it would give us the real confidence we want in a test. Pasting the full snippet here for posterity: ```js const nock = require('nock') //...

Awesome, looks good!

Better yet, introduce a "patternToReject" (for lack of a better name) key: ```json { "labels.names": [ { "pattern": "ready", "message": "Please add a 'ready' label" }, { "patternToReject": "dont-merge", "message":...

The malicious SHA is `a0c461c94ba9f1573c7253666d218b3343d24bfa5d8ef270ee9bc74b7856e492`. This SHA points to https://www.cisa.gov/uscert/ncas/analysis-reports/ar21-048d and something called Kupay Wallet.

I'm also interested in this but I found a workaround for the time being. I'm using the advanced setting "MQTT topics to publish on start-up", so I can publish an...

If anyone is willing to switch to npm, they already have support for this via `npm install --only=dev`. I would love to see this ported over to yarn though.

https://jsonnet.org/ might be appropriate too