Joachim Jablon
Joachim Jablon
Wouldn't it be worth adding the country (or group) as translation context ? Maybe "Labour day" would be called differently in a language depending on if it's the country's Labour...
I'm not sure I agree. Providing each name in local language + english would useful for a vast majority of cases. What really is debatable (and it doesn't even mean...
(Even if it's not the same question exactly and all, I think it's interesting to link this to a previous ticket that sparked related conversations https://github.com/peopledoc/workalendar/issues/346)
I think we might need a different API where holidays would be objects, not strings. (dataclasses would probably be nice). We would then be able to query different attributes of...
Yeah but it's highly dependent on the consistency of human-readable names, and depending on how we implement localization, it may completely break. I'm not advocating for a change in the...
So, we're using `add_sync_api` less and less in our external API, so this doesn't make as much sense as it used to. I wonder if we could just provide type...
I think we need to decide of an approach: - either we try to make the Django Connector as close as possible to the Psycopg2 connector, and undo all the...
I don't see the difference between your 3rd approach and my 1st ?
Ah ok, I understand your point. I had forgotten that the Psycopg2Connector was incompatible with workers. But then it seems it would be easier to make the Psycopg2Connector compatible with...
Hey :) I feel a bit ashamed that I let this PR rot :/ I felt that I needed to discuss it with other maintainers and it never really happenned...