pygrowup icon indicating copy to clipboard operation
pygrowup copied to clipboard

Calculator is maybe not true

Open binhmuc opened this issue 6 years ago • 2 comments

Hi, I run your example code at 02/Nov/2018. Your code example is 9 months ago. So the day of birth is 02/Feb/2018. But your function "helpers.date_to_age_in_months" is calculate valid_age is: 8 ( i think 9 is correct, because 9 months ago, right ?) Maybe your code. def date_to_age_in_months(date): delta = datetime.date.today() - date print (delta.days / 30.4375) #years = delta.days / 365.25 return str(int(delta.days / 30.4375)) In file helper is wrong, delta.days / 30.4375 = 8.969199178644764 and return 8.

binhmuc avatar Nov 02 '18 02:11 binhmuc

hi @binhmuc – you might want to instead check out my rewritten version which lives here: https://github.com/jbaldivieso/pygrowup2 (the long term hope was to have that ultimately replace pygrowup, but we haven't tackled that code merging yet). The API is different, but it features some improvements in terms of accuracy.

jbaldivieso avatar Nov 19 '18 19:11 jbaldivieso

Thank for you reply, bro. Anyway, your work is so great. Do you know WHO also public dataset base on date also ?.

binhmuc avatar Nov 20 '18 01:11 binhmuc