faiss-node icon indicating copy to clipboard operation
faiss-node copied to clipboard
verified publisher icon ewfian

Labels are 64bit but JS bindings were limited to 32bit

Open asilvas opened this issue 2 years ago • 4 comments

An important change for large indexes, and precursor to supporting vector identifiers where index is insufficient. Faiss already natively uses 64bit labels, this PR just prevents the conversion loss.

asilvas avatar Sep 24 '23 22:09 asilvas

Let me know if you prefer these small PR's or one bigger one. Have quite a few improvements planned.

asilvas avatar Sep 29 '23 01:09 asilvas

Let me know if you prefer these small PR's or one bigger one. Have quite a few improvements planned.

Thank you very much for your series of improvements. Small PR's are preferred

ewfian avatar Sep 30 '23 13:09 ewfian

@asilvas Thank you for this pr, but considering the following points, I would like to put this pr aside. Maybe we can provide another API to deal with 64bit issues in the future.

  1. This modification will brings break changes and cause great trouble to downstream users.
  2. Number and BigInt are not interoperable. Generally, users are more familiar with number, and using number will have better compatibility with other libraries.
  3. Generally speaking, if a user uses javascript, I do not expect him to have sufficient requirements for performance and data volume.

ewfian avatar Oct 02 '23 07:10 ewfian

If you're not interested in serious improvements you can close my PR's and I'll move to fork.

asilvas avatar Oct 02 '23 13:10 asilvas