testnet
testnet copied to clipboard
ewasm
Dynamic dockerfile
This PR parameterizes the invocation of cpp-eth.sh and adds support for building dynamically-versioned docker containers such that the resulting container includes the targeted versions of the Hera VM and cpp-ethereum, among other things.
In the future, other node implementations and VMs can be supported using the same method now in setup.sh.
@kthomas thanks for the work! It may take a bit to review it, but perhaps breaking up this PR into smaller changes (as separate PRs) could speed up the process.
Looks great @kthomas ! I need to do a bit of work with our provisioning scripts to incorporate this and then we will merge it.
Hey @kthomas , sorry for the lapse in response. We've decided to change direction and use Geth as our main client for the testnet. I will leave this open for now in case anyone else has any input.
Thanks for the heads-up Jared.
I have support for geth and parity using that same pattern; would you like me to update the PR with that support?
Cheers... On Sun, Aug 26, 2018 at 3:24 PM Jared Wasinger [email protected] wrote:
Hey @kthomas https://github.com/kthomas , sorry for the lapse in response. We've decided to change direction and use Geth as our main client for the testnet. I will leave this open for now in case anyone else has any input.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ewasm/testnet/pull/50#issuecomment-416062994, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJ17c-BA5xRB72wOf2q2s65gWF7NP5Jks5uUvXXgaJpZM4VfcvW .
This could be useful if we end up running an aleth node on the testnet. It needs to be updated to reflect changes in evmc.