testnet icon indicating copy to clipboard operation
testnet copied to clipboard

Published 20 hours ago • verified publisher icon ewasm

Some misc README cleanup

Open lrettig opened this issue 6 years ago • 19 comments

Saving work in progress. Going to try to merge some in flight PRs and rebase against those.

lrettig avatar Nov 13 '18 16:11 lrettig

#96 was merged, please rebase.

axic avatar Nov 14 '18 00:11 axic

This is ready to go but will likely conflict with #115

lrettig avatar Nov 15 '18 02:11 lrettig

Rebased - because it was hard to follow what is going on with merge commits.

axic avatar Nov 15 '18 17:11 axic

From my perspective this is ready to merge, @axic ?

lrettig avatar Nov 17 '18 01:11 lrettig

Is this ready to go? Ping

lrettig avatar Nov 22 '18 03:11 lrettig

I'm not sure why wagon was moved out of the main doc.

axic avatar Nov 26 '18 12:11 axic

I'm not sure why wagon was moved out of the main doc.

I moved it into a side doc because it's not ready for production yet. I did the same thing for aleth. Would prefer to keep the master doc as focused and simple as possible. @axic is there a reason you want it in the main doc?

lrettig avatar Nov 26 '18 14:11 lrettig

I've pulled out two major changes from here and merged them separately.

is there a reason you want it in the main doc?

Wagon is ready and passing the tests (as of yesterday). It is planned to be the main client for 2nd milestone. Don't wanna move it back and forth.

axic avatar Nov 26 '18 14:11 axic

Then can we remove the part that says "this spec may be wrong and will change"?

On Mon, 26 Nov 2018 at 14:47, Alex Beregszaszi [email protected] wrote:

I've pulled out two major changes from here and merged them separately.

is there a reason you want it in the main doc?

Wagon is ready and passing the tests (as of yesterday). It is planned to be the main client for 2nd milestone. Don't wanna move it back and forth.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ewasm/testnet/pull/102#issuecomment-441663616, or mute the thread https://github.com/notifications/unsubscribe-auth/ADKbNHe942084yOFpXRkHMAigiMozdPGks5uy_7ogaJpZM4YcD7o .

lrettig avatar Nov 26 '18 14:11 lrettig

@gballet is wagon working now properly? Can we remove the warning?

axic avatar Nov 26 '18 15:11 axic

@gballet ping https://github.com/ewasm/testnet/pull/102#issuecomment-441668640

axic avatar Nov 29 '18 10:11 axic

@axic wagon is working with some issue that I found, need to create the PR for the fix and have them integrate them.

gballet avatar Dec 03 '18 22:12 gballet

Did you remove the assemblyscript docs via force push? 😑

lrettig avatar Dec 06 '18 08:12 lrettig

Did you remove the assemblyscript docs via force push? 😑

Didn't remove any assemblyscript docs.

axic avatar Dec 06 '18 10:12 axic

Can we just merge this, then update the wagon stuff later as necessary?

lrettig avatar Dec 11 '18 14:12 lrettig

Can we just merge this, then update the wagon stuff later as necessary?

There is little point applying all these wagon changes from this PR if we need to roll it back 100%. Wagon just works.

axic avatar Dec 12 '18 15:12 axic

It would be great to get this merged, and iterate. There's a bunch of confusing/misleading stuff in the master doc right now that this fixes.

lrettig avatar Dec 15 '18 08:12 lrettig

There's a bunch of confusing/misleading stuff in the master doc right now that this fixes.

Can you please list what is this fixing? The C++/Rust swap is not relevant anymore, Wagon is not experimental anymore.

axic avatar Dec 17 '18 11:12 axic

This PR is not about C++/Rust or Wagon. It's about misc doc cleanup. The bulk of these changes are still relevant. Is there some specific concern here? If not, can we merge and iterate?

lrettig avatar Dec 27 '18 11:12 lrettig