ewasm-kernel icon indicating copy to clipboard operation
ewasm-kernel copied to clipboard

Published 20 hours ago • verified publisher icon ewasm

Fix storageStore/storageLoad key/value endianess

Open hugo-dc opened this issue 7 years ago • 5 comments

all vm tests passing in evm2wasm, the problem was the same as in storageStore

hugo-dc avatar May 10 '18 05:05 hugo-dc

Actually of the points of U256.fromMemory was to deal with endianness.

axic avatar May 10 '18 08:05 axic

what axic said, we want to make the change in u256.js. see also https://github.com/ewasm/ewasm-kernel/pull/6

cdetrio avatar May 11 '18 17:05 cdetrio

Just tried this change, I'm still seeing some failures:

1..1792
# tests 1792
# pass  1732
# fail  60

lrettig avatar May 22 '18 20:05 lrettig

@lrettig I changed u256.js as @axic suggested, right now I have 40+ failing tests still have to figure out what is causing them.

hugo-dc avatar May 22 '18 20:05 hugo-dc

@hugo-dc is that code in the same branch? If so could you push the change? 🙏

lrettig avatar May 23 '18 20:05 lrettig