evm2wasm icon indicating copy to clipboard operation
evm2wasm copied to clipboard

Published 20 hours ago • verified publisher icon ewasm

Support new call interface

Open axic opened this issue 7 years ago • 4 comments

  • return values have been changed
  • return value isn't written to be a paramater but retrieved via returndatacopy

axic avatar Jan 26 '18 21:01 axic

Cf:

  • https://github.com/ethereum/EIPs/pull/211
  • https://github.com/ethereum/EIPs/blob/master/EIPS/eip-211.md
  • https://github.com/ewasm/design/issues/70
  • https://github.com/ewasm/design/pull/74

lrettig avatar Mar 16 '18 23:03 lrettig

Need to add:

  • RETURNDATASIZE
  • RETURNDATACOPY

(Cf. https://github.com/ethereum/ethereumj/pull/919/files#diff-e2305a94a8fe46fe43860fc9ed6a5eacR789)

Need to update:

  • CALL (call)
  • CALLCODE (callCode)
  • DELEGATECALL (callDelegate)
  • CALLSTATIC (callStatic to be added in #163)

lrettig avatar Mar 16 '18 23:03 lrettig

@axic: to be clear, the CREATE opcode and EEI methods have not changed--it's just that they clear the return data buffer, right? So CREATE does not need to change in evm2wasm, since this will happen at a lower level, right?

lrettig avatar Mar 17 '18 00:03 lrettig

CALLSTATIC (callStatic to be added in #163)

This is actually called STATICCALL in EVM.

to be clear, the CREATE opcode and EEI methods have not changed--it's just that they clear the return data buffer, right?

Yeah actually CREATE doesn't need to be changed.

axic avatar Mar 23 '18 01:03 axic