design icon indicating copy to clipboard operation
design copied to clipboard

Remove revision number from top-level README

Open lrettig opened this issue 6 years ago • 8 comments

Nothing in this doc is versioned and it's confusing to lead with this. Let's just version the actual specification docs (https://github.com/ewasm/design/blob/master/contract_interface.md, https://github.com/ewasm/design/blob/master/eth_interface.md, https://github.com/ewasm/design/blob/master/system_contracts.md).

lrettig avatar May 07 '19 18:05 lrettig

I'm not sure I understand. It is versioned and this version in the README is the version number.

axic avatar May 07 '19 21:05 axic

Last August we've argued that a single version is more readable, hence #146 was merged.

axic avatar May 07 '19 22:05 axic

I'm approaching this from a readability perspective. For someone landing on this page trying to learn about Ewasm, it's confusing that the very first thing they see is a version number. What in this doc specifically (README.md) depends on the version number?

lrettig avatar May 07 '19 23:05 lrettig

Is removing a version number entirely from the repository a good approach? Is that version number line the biggest issue with the README right now?

axic avatar May 07 '19 23:05 axic

The revision number exists in other files: https://github.com/ewasm/design/commit/69b3e41af2975dbe56171417bfeee75f19ae1f64#diff-04c6e90faac2675aa89e2176d2eec7d8. I don't see why it belongs in this file. I'm tackling other README stuff in #192.

lrettig avatar May 08 '19 00:05 lrettig

The revision number exists in other files:

Existed before #146 was merged. The only version is in the README.

axic avatar May 08 '19 00:05 axic

well, that's a problem :)

lrettig avatar May 08 '19 00:05 lrettig

Existed before #146 was merged. The only version is in the README.

Sorry I missed this fact originally. I created a separate revision file. @axic is this better?

Honestly, the real issue here is that this repo presently serves two different purposes: containing the spec itself, and containing high-level documentation on Ewasm. Just trying to draw a line and be a bit more explicit about this.

lrettig avatar May 08 '19 16:05 lrettig