Ewald Comhaire

Results 57 comments of Ewald Comhaire

This compiles correctly and register _SVGExternalFileResolver_ properly. If I understood correctly, the init function of an object is executed only once and the debugger seems to confirm this. But the...

One more try: ``` open class SVGClient { var client: HttpClient? = null companion object : SVGExternalFileResolver() { init { SVG.registerExternalFileResolver(this) } var client: HttpClient? = null override fun resolveFont(fontFamily:...

Tried several solutions but could not find a good way to get around the multi-thread issue besides using a shared mutex around these two statements. The callback should be made...

In the meantime, I found out why @import was not triggering the callback. There is a defect in the CSS parser. I will file an issue report (and perhaps a...

Can't see how to fix [BigBadaboom/androidsvg#199](https://github.com/BigBadaboom/androidsvg/issues/199) with a totally static library. Will require the instantiation of a SVG object IMHO to store the context (or unique ID of some kind)...

I now have my own fork of [androidsvc ](https://github.com/ewaldc/androidsvg ) published in jitpack.io so I can fix defects and test with OH-android build. Already fixed the two issues I submitted......

Finally, it's working but since it requires a (minor) fix to androidsvg, I can't just provide a PR for just OH-android only. It's running [here](https://github.com/ewaldc/openhab-android) I had to extend the...

Implemented all optimizations you suggested and fixed indentation. `runBlocking` works as a charm (learning all the time!). It's a much smaller and cleaner change now: - no extension of HttpClient...

I think it's missing the fix for [resolving external CSS files](https://github.com/BigBadaboom/androidsvg/issues/200)? Without this fix AndroidSVG will never even call the (now modified) resolver :-)

Understood, the only challenge is that without this change, SVG Android will not invoke _externalFileResolver.resolveCSSStyleSheet(file);_ since the mediaList will be of size zero. What I can try is to change...