nwjs-builder icon indicating copy to clipboard operation
nwjs-builder copied to clipboard

Using `--version` shows an nwjs-builder package version and does nothing (unlike -v).

Open CosmoMyzrailGorynych opened this issue 9 years ago • 2 comments

Like so:

$ D:\_namespace\_cosmicEveryday>nwb nwbuild --production --version v0.19.5 --platforms win32,win64 --win-ico ico.ico --output-dir D:\_namespace\_cosmicEverydayBuilds\

1.14.0

And then the process exits.

Intended behaviour: download nwjs and start packaging; --version should specify an nw.js version for download, like in --help command:

default

-v flag works well, though.

CosmoMyzrailGorynych avatar Jan 13 '17 09:01 CosmoMyzrailGorynych

Ouch. That should be something with the commander dependency, which is used to parse command line arguments in nwjs-builder. Thanks for the issue and I will look into it soon.

evshiron avatar Jan 13 '17 09:01 evshiron

Hmm, after reading the code of commander, I think removing this line should do the trick.

evshiron avatar Jan 13 '17 10:01 evshiron