Evshiron Magicka

Results 99 comments of Evshiron Magicka

You need to set options in `./app/package.json`, not the `package.json` in the current directory, which isn't read when you pass `app` as the path to the `build` command.

What about this: ```javascript "excludes": [ "./node_modules/**/*" ] ``` BTW, `node_modules` of `devDependencies` is ignored by default. If a module is used only in development, make it a `devDependency`.

Code is located [here](https://github.com/evshiron/nwjs-builder-phoenix/blob/master/src/lib/Builder.ts#L391). I get it to work with: ```javascript "excludes": [ "**/node_modules", "**/node_modules/**/*" ] ``` I have no idea why `./node_modules` doesn't work and I will check it...

Emmm. Is this `buffer-equal` listed in your `dependencies`? Do you have any anti-virus softwares? If so, please disable it temporarily and see if `rcedit` works. A reproducible sample will be...

When you install dependencies via `npm install`, you should use `--save` or `--save-dev` to save them to the `package.json`. This is how node.js works. `nwjs-builder-phoenix` will only copy production dependencies...

NSIS is zlib/libpng licensed, so it should be safe to include in this repo. Writing NSIS scripts seems painful, and I should firstly give [NSIS Quick Setup Script Generator](http://nsis.sourceforge.net/NSIS_Quick_Setup_Script_Generator) a...

At the moment, we should be able to generate diff scripts from two directories. Here comes the question, how should `nwjs-builder-phoenix` be able to know which versions to diff with?...

Hmm. I am going to bundle Modern UI 2 for simple installer building, and thinking about ways to support custom scripts.

I am considering using mechanisms like [what `electron-builder` does](https://github.com/electron-userland/electron-builder/tree/master/packages/electron-builder/templates/nsis#compression), it does provide faster and better compression. BTW concurrent building might also be considered, as every `Builder.buildTask` should not interfere as...

Integration of `nsis7z` has greatly reduced building time to around 2/3 (from 150 seconds to 100 seconds).