php-cassandra-binary icon indicating copy to clipboard operation
php-cassandra-binary copied to clipboard

Revert 6f1cae9 because it caused a lot of troubles...

Open andreassolberg opened this issue 9 years ago • 1 comments

It fixes #35

Someone should take a closer look at what the 6f1cae9 did intend to fix, and reapply a patch that does not break so fundamentally.

It might very be that these issues only affect more recent versions of cassandra, as not all users are experiencing them. See #35 and 6f1cae9 for more details.

andreassolberg avatar Nov 27 '14 10:11 andreassolberg

Hey @andreassolberg - can you maybe write a regression test for the case that broke for you so we can ensure that whenever we change the function again it will work for your use-case?

-> https://github.com/evseevnn/php-cassandra-binary/blob/master/tests/Cases/PositiveIntTest.php and https://github.com/evseevnn/php-cassandra-binary/blob/master/tests/Cases/NegativeIntTest.php

LarsFronius avatar Nov 28 '14 11:11 LarsFronius