helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Allowing user to configure global and per-tier labels

Open syalioune opened this issue 2 years ago • 6 comments

Thanks for maintaining this chart.

The purpose of this PR is to give more flexibility by allowing users to provide common and per tier (frontend/backend) labels. Existing labels have been integrated into default values file.

syalioune avatar Aug 26 '22 12:08 syalioune

Hello @davidkarlsen, I see that linters are failing since the chart version did not change. I was not sure if version bump was at the discretion of maintainers. Do you expect a commit from me to set chart version to 1.4.2 ? Thanks

syalioune avatar Sep 21 '22 22:09 syalioune

Yes please so that it can pass CI

davidkarlsen avatar Sep 22 '22 00:09 davidkarlsen

Done :smiley:

syalioune avatar Sep 22 '22 10:09 syalioune

Hello @davidkarlsen, it's been done !

syalioune avatar Oct 10 '22 11:10 syalioune

Hello David, any issues preventing merging this branch ?

syalioune avatar Nov 06 '22 19:11 syalioune

I would also like to ask kindly for a merge.

hardwarefresser avatar May 10 '23 12:05 hardwarefresser