docker-oidc-proxy icon indicating copy to clipboard operation
docker-oidc-proxy copied to clipboard

Add PKCE support

Open R0Wi opened this issue 4 years ago • 2 comments

Since https://github.com/zmartzone/lua-resty-openidc/pull/320 is now merged in the lua-resty-openidc-project, we can now use use_pkce variable to optionally enable PKCE support like described in this draft: https://tools.ietf.org/html/draft-parecki-oauth-v2-1-01.

Note: do not merge this PR until the next version of lua-resty-openidc (which is hopefully 1.7.3) is released. Currently the patch is only available in the master-branch of the mentioned project.

R0Wi avatar Sep 04 '20 05:09 R0Wi

lua-resty-openidc 1.7.3 is now released, which includes support for PKCE, see: https://github.com/zmartzone/lua-resty-openidc/releases/tag/v1.7.3

zandbelt avatar Sep 10 '20 16:09 zandbelt

Ok then this should work. I tested it with my personal fork.

R0Wi avatar Sep 10 '20 16:09 R0Wi

@zandbelt any chance to get this merged?

R0Wi avatar Nov 05 '22 22:11 R0Wi

@zandbelt any chance to get this merged?

I'm not the repo owner, this is a docker-oidc-proxy matter, not lua-resty-openidc

zandbelt avatar Nov 07 '22 09:11 zandbelt

Sorry, forgot to check maintainers. Maybe @Starefossen could have an eye on this?

R0Wi avatar Nov 07 '22 09:11 R0Wi

No longer employed by @evry unfortunately 😢 Maybe @AndersRunningen, @bjorges, @ekarlso, or @varneberg could have a look at this? 🙏🏻

Starefossen avatar Nov 07 '22 09:11 Starefossen