Rank by points

[IzStriker]

Partially addresses #524 When choosing teams from a previous stage, teams can now either be ranked by the highest elo or the highest amount of points accumulated across matches.

[vercel[bot]]

@IzStriker is attempting to deploy a commit to the evroon's projects Team on Vercel.

A member of the Team first needs to authorize it.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.77%. Comparing base (7bc0048) to head (4a3b5ed). Report is 106 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #749      +/-   ##
==========================================
+ Coverage   92.72%   92.77%   +0.04%     
==========================================
  Files         108      108              
  Lines        3727     3749      +22     
==========================================
+ Hits         3456     3478      +22     
  Misses        271      271              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[evroon]

Thanks for the PR, I hope to be able to look at it within a few days

[evroon]

Hmm I looked at it but I am not sure this is the way to go. I would prefer something more flexible, like how other tournament systems have a scoring system.

There you can kind of "design" your scoring, and specify how much game_points a win attributes to for example.

So what I think we want is a table of scorings, and each row in that table contains settings as to how the scoring works. So how many points are awarded per win and per tie for example. Most tournaments will just use one kind of scoring. Later we can extend this system to also take into account scoring for forfeits, "bye"s, scoring of sets within matches etc. It also lets you define tie-breaking criteria, but that can wait for another time.

There's also two things that are currently a bit of a mistake in my implementation:

• we don't keep track of a team's (or player's) score within a stage item, which is essential to calculate the score correctly
• "Number of teams advancing from the previous stage" should probably instead be "Number of teams advancing to the next stage", that makes more sense.

Sorry I didn't come up with this earlier. What do you think of this approach?

[IzStriker]

Hmm I looked at it but I am not sure this is the way to go. I would prefer something more flexible, like how other tournament systems have a scoring system.

There you can kind of "design" your scoring, and specify how much game_points a win attributes to for example.

So what I think we want is a table of scorings, and each row in that table contains settings as to how the scoring works. So how many points are awarded per win and per tie for example. Most tournaments will just use one kind of scoring. Later we can extend this system to also take into account scoring for forfeits, "bye"s, scoring of sets within matches etc. It also lets you define tie-breaking criteria, but that can wait for another time.

There's also two things that are currently a bit of a mistake in my implementation:

• we don't keep track of a team's (or player's) score within a stage item, which is essential to calculate the score correctly
• "Number of teams advancing from the previous stage" should probably instead be "Number of teams advancing to the next stage", that makes more sense.

Sorry I didn't come up with this earlier. What do you think of this approach?

I think understand what you're suggesting. However, I implemented the scoring system in this PR because it's the system my local club uses to score tournaments. I don't think I could achieve the same system with what you're describing unless I am misunderstanding and this would have to exist along side your suggestion to be able to rank by points. Let me know if I'm missing something.

[evroon]

I'm working on a draft here: https://github.com/evroon/bracket/pull/797

Ah I think I understand now what you mean why it wouldn't work. It's because you add the number of points in the match as ranking, not the result of the match (win or loss). I should be able to implement that in my PR. If you want to write code, I can also skip that part (but make it easy to implement) and let you do that.

[IzStriker]

I'm not fused about writing code, but let me know if you want help with anything. Also, if you don't need this PR feel free to close it. 🙂

[github-actions[bot]]

This PR is stale because it has been open for 45 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

[evroon]

I have implemented my idea in https://github.com/evroon/bracket/pull/797, with support (from what I understand) for your use case. There is a checkbox you can check when creating a ranking to enable adding the score to the amount of points of a team.

So then I'll close this RP, if something is missing, feel free to create an issue and I'll see if I can add it.

Thanks for all the effort anyway!