bracket icon indicating copy to clipboard operation
bracket copied to clipboard

Fix backend to recalculate start time on match update

Open robigan opened this issue 1 year ago • 10 comments

robigan avatar Mar 06 '24 13:03 robigan

Someone is attempting to deploy a commit to a Personal Account owned by @evroon on Vercel.

@evroon first needs to authorize it.

vercel[bot] avatar Mar 06 '24 13:03 vercel[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.25%. Comparing base (0f1cde5) to head (7293010). Report is 209 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
- Coverage   90.40%   90.25%   -0.15%     
==========================================
  Files         123      124       +1     
  Lines        3938     4002      +64     
==========================================
+ Hits         3560     3612      +52     
- Misses        378      390      +12     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 06 '24 13:03 codecov[bot]

Made draft as I need to make some test cases first tbh

robigan avatar Mar 06 '24 13:03 robigan

This PR is stale because it has been open for 45 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar May 05 '24 08:05 github-actions[bot]

Yes github bot I'm aware, also being away from the machine with all the necessary changes is hard too

robigan avatar May 29 '24 18:05 robigan

This PR is stale because it has been open for 45 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Jun 30 '24 08:06 github-actions[bot]

Got round to testing, not sure why this shouldn't work

robigan avatar Jul 10 '24 10:07 robigan

Well, I should say that it's been working in production for us for a long while, I haven't tested on a local machine but I'm pretty sure it's been working very reliably for long. Shall I attempt to add a test for this @evroon ? image

robigan avatar Jul 10 '24 10:07 robigan

If you could add a test, that would be nice indeed!

evroon avatar Jul 10 '24 10:07 evroon

If you could add a test, that would be nice indeed!

"100% of diff hit" according to CodeCov, so there you have it 👍

robigan avatar Jul 15 '24 13:07 robigan

This PR is stale because it has been open for 45 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

github-actions[bot] avatar Aug 16 '24 08:08 github-actions[bot]

@evroon ?

robigan avatar Aug 19 '24 15:08 robigan

Sorry for the delay, thanks for fixing this bug!

evroon avatar Sep 01 '24 17:09 evroon