Frontend improvements for match rescheduling

[robigan]

PR to support custom schedules instead of the automatic ones.

Discussed in #519

[vercel[bot]]

Someone is attempting to deploy a commit to a Personal Account owned by @evroon on Vercel.

@evroon first needs to authorize it.

[robigan]

I have just realized, there already is a match component. With the custom duration built in. Mfw

[github-actions[bot]]

This PR is stale because it has been open for 45 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

[github-actions[bot]]

This PR is stale because it has been open for 45 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

[robigan]

Actually I should so some testing but I gtg

[robigan]

@evroon We have our UI setup like this, but I saw that you made a change where onClick of the schedule row's card it opens the update model. I feel like the whole tap a card thing to open is more of a mobile thing, and on desktop isn't clear that it can be clicked, plus the drag mouse UI doesn't help either to indicate it is clickable. You introduced the change in https://github.com/evroon/bracket/commit/24f04fbaa0f1aafe59e44ca53a0b378705507296

[evroon]

@evroon We have our UI setup like this, but I saw that you made a change where onClick of the schedule row's card it opens the update model. I feel like the whole tap a card thing to open is more of a mobile thing, and on desktop isn't clear that it can be clicked, plus the drag mouse UI doesn't help either to indicate it is clickable. You introduced the change in 24f04fb

Hmm how would you improve it? Have some kind of button like the green pencil one in your screenshot that opens the modal?

[evroon]

I'm not sure I understand what this PR does. What problem does this PR solve exactly? I guess what it does is allow you to enter a datetime instead of margins/durations, but what is the use case it targets?

[robigan]

@evroon We have our UI setup like this, but I saw that you made a change where onClick of the schedule row's card it opens the update model. I feel like the whole tap a card thing to open is more of a mobile thing, and on desktop isn't clear that it can be clicked, plus the drag mouse UI doesn't help either to indicate it is clickable. You introduced the change in 24f04fb

Hmm how would you improve it? Have some kind of button like the green pencil one in your screenshot that opens the modal?

Yup, we had this same UI problem with the old schedule page, I see you've removed. It just wasn't clear to our tournament staff they had to click to edit the match

[robigan]

I'm not sure I understand what this PR does. What problem does this PR solve exactly? I guess what it does is allow you to enter a datetime instead of margins/durations, but what is the use case it targets?

Originally, there was no proper way to edit the custom duration/delay fields of matches, nor was it intuitive, and our staff thought that they had to do it from the planning page. And aimed to add that functionality, this PR now basically adds some QoL features such as having functionality to calculate the delay required if you want the next match to start at a certain time, and adding that button to hint to the user they can actually edit the card. In terms of DX, I also added some typings pertaining the parts of code I touched but I could add more typings

[robigan]

Oh, and cleaned up some typings and added some code optimizations.

[robigan]

Gotta still test some things, this isn't exactly merge ready

[robigan]

Actually yeah the rest of the type system is complaining, I might might just type everything

[github-actions[bot]]

This PR is stale because it has been open for 45 days with no activity. Remove the stale label or comment or this will be closed in 30 days.

[robigan]

@evroon ?

[evroon]

I like the typing improvements.

Regarding the functionality changes, I'm less sure. For now, tournaments in bracket happen on one date, so showing the date doesn't really have added value right?

But I'm still not very sure what this PR adds exactly, here for example.

[robigan]

I like the typing improvements.

Regarding the functionality changes, I'm less sure. For now, tournaments in bracket happen on one date, so showing the date doesn't really have added value right?

But I'm still not very sure what this PR adds exactly, here for example.

Sorry for the late reply, school got in the way. For us, and from the way I've been seeing other issues arise, it could be that others use Bracket for multi-day tournaments. As for the latter functionality, it allowed our team to easily readjust matches start times and dates by giving them a date picker

[github-actions[bot]]

This PR is stale because it has been open for 45 days with no activity. Remove the stale label or comment or this will be closed in 30 days.