react-native-fcm icon indicating copy to clipboard operation
react-native-fcm copied to clipboard

Consider re-openning this repo

Open cargallo opened this issue 5 years ago • 12 comments

react-native-firebase is no longer developing a solution for notification in V6 version. So, please reconsider the repo deprecation

cargallo avatar Jan 08 '20 16:01 cargallo

I would +1 this so bad, I'm still using this repo in my 10+ on-going projects right now

phatlaunchdeck avatar Jan 09 '20 05:01 phatlaunchdeck

+1

Desintegrator avatar Jan 22 '20 06:01 Desintegrator

+1

danielvportlandia avatar Feb 04 '20 18:02 danielvportlandia

+1

vomchik avatar Feb 19 '20 12:02 vomchik

Here is a link explaining the drop in support for notifications that came from the RNF v6 jump.

https://github.com/invertase/react-native-firebase/issues/2566#issuecomment-562700412

This repo is quite relevant and valuable to the community. Not sure if @evollu is interested in resurecting for open source input.

temitope avatar Feb 28 '20 20:02 temitope

@evollu You have any thinking over this yet?

phatlaunchdeck avatar Apr 18 '20 17:04 phatlaunchdeck

FYI: in react-native-firebae v6.4.0 was add two methods for notifacion, getInitialNotification and onNotofocationOpened. I think it will be enough for most apps.

vomchik avatar Apr 19 '20 06:04 vomchik

@vomchik I haven't used react-native-firebase for a while now, but by the sound of those methods, I would assume that onNotificationOpened only get triggered when the user taps onto the notification, and that is not enough since on all of my projects, the data needs processing as soon as notification comes in, not when the user taps on it.

phatlaunchdeck avatar Apr 19 '20 06:04 phatlaunchdeck

I see, but if you want to catch a incoming notification in the foreground please use onMessage handler.

vomchik avatar Apr 19 '20 06:04 vomchik

Well that would do for the foreground case, but what if when the app is running but in the background? Any method for that or would the onMessage() handle that case too?

phatlaunchdeck avatar Apr 19 '20 06:04 phatlaunchdeck

As far I remember it also will be handled by onMessage, please check a documentation 🕵️‍♂️

vomchik avatar Apr 19 '20 06:04 vomchik

Ah if so that would be nice, I'll check it out, thanks!

However, I still would like @evollu to re-open this repo regardless. I've been forking this repo to fix AndroidX support along with some other bug fixes but if he's not coming back I might have to dig up my rusty Java skill from college again to add support for new features of FCM.

phatlaunchdeck avatar Apr 19 '20 07:04 phatlaunchdeck