evmos icon indicating copy to clipboard operation
evmos copied to clipboard

imp(distribution): replace bech32 address with evm hex address for distribution precompile contract

Open luchenqun opened this issue 2 years ago • 6 comments

Description

Please review https://github.com/evmos/evmos/pull/2200 first, because this is modified based on this PR

More details see before https://github.com/evmos/evmos/pull/2122

luchenqun avatar Jan 05 '24 16:01 luchenqun

Codecov Report

Attention: Patch coverage is 77.55102% with 33 lines in your changes missing coverage. Please review.

Project coverage is 70.42%. Comparing base (aa0b9d5) to head (3e4e459). Report is 214 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2241      +/-   ##
==========================================
- Coverage   70.53%   70.42%   -0.11%     
==========================================
  Files         291      291              
  Lines       22617    22657      +40     
==========================================
+ Hits        15953    15957       +4     
- Misses       5798     5822      +24     
- Partials      866      878      +12     
Files Coverage Δ
precompiles/distribution/tx.go 67.07% <0.00%> (ø)
precompiles/distribution/events.go 75.22% <62.50%> (-2.55%) :arrow_down:
precompiles/distribution/query.go 82.85% <40.00%> (-8.24%) :arrow_down:
precompiles/distribution/types.go 89.14% <87.75%> (-3.65%) :arrow_down:
precompiles/staking/types.go 87.28% <76.19%> (-0.05%) :arrow_down:

... and 3 files with indirect coverage changes

codecov[bot] avatar Jan 05 '24 16:01 codecov[bot]

When executing the make lint-fix command, the following errors are found, but in fact they are only partially duplicated. How do you usually fix these problems?

Error: 64-89 lines are duplicate of `precompiles/distribution/types.go:92-117` (dupl)
  Error: 92-117 lines are duplicate of `precompiles/distribution/types.go:64-89` (dupl)
  Error: 57-77 lines are duplicate of `precompiles/distribution/events_test.go:129-149` (dupl)
  Error: 129-149 lines are duplicate of `precompiles/distribution/events_test.go:57-77` (dupl)
  Error: 504-513 lines are duplicate of `precompiles/distribution/integration_test.go:1[36](https://github.com/evmos/evmos/actions/runs/7424496428/job/20204246603?pr=2241#step:5:38)7-1376` (dupl)
  Error: 1367-1[37](https://github.com/evmos/evmos/actions/runs/7424496428/job/20204246603?pr=2241#step:5:39)6 lines are duplicate of `precompiles/distribution/integration_test.go:504-513` (dupl)

luchenqun avatar Jan 06 '24 03:01 luchenqun

The PR looks good, but we need the same typescript library mentioned in #2200 in order to give solutions to the tools already created for our users.

We should be able to finish the review and merge it as soon as the typescript lib is available.

hanchon avatar Jan 18 '24 19:01 hanchon

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.

github-actions[bot] avatar Mar 04 '24 00:03 github-actions[bot]

Not Stale

VictorTrustyDev avatar Mar 04 '24 07:03 VictorTrustyDev

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.

github-actions[bot] avatar Apr 19 '24 00:04 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.

github-actions[bot] avatar Jun 04 '24 00:06 github-actions[bot]

@luchenqun can you reopen this PR? I'll close this as it has too many conflicts

fedekunze avatar Jun 04 '24 13:06 fedekunze