ethermint icon indicating copy to clipboard operation
ethermint copied to clipboard

RPC: Change timeout to `time.duration` on `traceTx`

Open crypto-facs opened this issue 3 years ago • 3 comments

Currently TraceConfig type on protobuf has Timeout as string and is later parse inside of the function. This Timeout parameter should be of type time.duration to avoid having this extra step.

This was done in the first place to comply with Go-Ethereum debug_traceTransaction grpc endpoint.

crypto-facs avatar Sep 04 '21 11:09 crypto-facs

@crypto-facs Addressed, PTAL #594.

iverc avatar Sep 28 '21 04:09 iverc

https://github.com/tharsis/ethermint/pull/594#issuecomment-928820789 @crypto-facs is there an issue on Go Ethereum for this?

tomtau avatar Oct 27 '21 09:10 tomtau

This issue is stale because it has been open 45 days with no activity. Remove Status: Stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Dec 12 '21 00:12 github-actions[bot]