ethermint icon indicating copy to clipboard operation
ethermint copied to clipboard

replace tm internal websocket with long poll

Open mmsqe opened this issue 2 years ago • 1 comments

Closes: https://github.com/crypto-org-chain/cronos/issues/665

Description


For contributor use:

  • [ ] Targeted PR against correct branch (see CONTRIBUTING.md)
  • [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • [ ] Code follows the module structure standards.
  • [ ] Wrote unit and integration tests
  • [ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • [ ] Added relevant godoc comments.
  • [ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • [ ] Re-reviewed Files changed in the Github PR explorer

For admin use:

  • [ ] Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • [ ] Reviewers assigned
  • [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

mmsqe avatar Sep 01 '22 01:09 mmsqe

Codecov Report

Merging #1321 (4678852) into main (1a5b64d) will increase coverage by 1.36%. The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1321      +/-   ##
==========================================
+ Coverage   55.16%   56.53%   +1.36%     
==========================================
  Files         105      105              
  Lines        9608     9609       +1     
==========================================
+ Hits         5300     5432     +132     
+ Misses       4043     3912     -131     
  Partials      265      265              
Impacted Files Coverage Δ
rpc/backend/call_tx.go 0.00% <0.00%> (ø)
rpc/backend/account_info.go 0.00% <0.00%> (ø)
rpc/backend/blocks_info.go
rpc/backend/blocks.go 87.76% <0.00%> (ø)

codecov[bot] avatar Sep 06 '22 01:09 codecov[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.

github-actions[bot] avatar Oct 26 '22 00:10 github-actions[bot]

@mmsqe closing this PR as it doesn't seem to be finished and it's been accumulated conflicts. Feel free to open a new PR against main

fedekunze avatar Dec 11 '22 12:12 fedekunze

@mmsqe closing this PR as it doesn't seem to be finished and it's been accumulated conflicts. Feel free to open a new PR against main

Got it, will try after this https://github.com/tendermint/tendermint/pull/9857 get update

mmsqe avatar Dec 11 '22 13:12 mmsqe