ethermint
ethermint copied to clipboard
replace tm internal websocket with long poll
Closes: https://github.com/crypto-org-chain/cronos/issues/665
Description
For contributor use:
- [ ] Targeted PR against correct branch (see CONTRIBUTING.md)
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the module structure standards.
- [ ] Wrote unit and integration tests
- [ ] Updated relevant documentation (
docs/
) or specification (x/<module>/spec/
) - [ ] Added relevant
godoc
comments. - [ ] Added a relevant changelog entry to the
Unreleased
section inCHANGELOG.md
- [ ] Re-reviewed
Files changed
in the Github PR explorer
For admin use:
- [ ] Added appropriate labels to PR (ex.
WIP
,R4R
,docs
, etc) - [ ] Reviewers assigned
- [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
Codecov Report
Merging #1321 (4678852) into main (1a5b64d) will increase coverage by
1.36%
. The diff coverage isn/a
.
Additional details and impacted files
@@ Coverage Diff @@
## main #1321 +/- ##
==========================================
+ Coverage 55.16% 56.53% +1.36%
==========================================
Files 105 105
Lines 9608 9609 +1
==========================================
+ Hits 5300 5432 +132
+ Misses 4043 3912 -131
Partials 265 265
Impacted Files | Coverage Δ | |
---|---|---|
rpc/backend/call_tx.go | 0.00% <0.00%> (ø) |
|
rpc/backend/account_info.go | 0.00% <0.00%> (ø) |
|
rpc/backend/blocks_info.go | ||
rpc/backend/blocks.go | 87.76% <0.00%> (ø) |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs.
@mmsqe closing this PR as it doesn't seem to be finished and it's been accumulated conflicts. Feel free to open a new PR against main
@mmsqe closing this PR as it doesn't seem to be finished and it's been accumulated conflicts. Feel free to open a new PR against
main
Got it, will try after this https://github.com/tendermint/tendermint/pull/9857 get update