Evan Martin
Evan Martin
Yes, that branch works. I would like to make a ticket upstream, let me see if I can reduce it into anything useful.
Given my current workaround is adequate, I think I would leave out your cursed patch (unless upstream thinks this is unfixable, maybe).
That does look like a race, hmm. The test runner runs the e2e tests in parallel threads, but they each spawn a separate n2 process so there should be no...
Oh wait, looking at the test, more likely it just didn't notice the directory changed. I will fix it.
I am sorta not sure what is going on here, because if the test usually passes that means we do see directory modifications. It looks like stat has high resolution...
BTW, if you run exe/rust/build.sh it builds a "threads.exe" program that can exercise some of this. https://github.com/evmar/retrowin32/blob/main/exe/rust/README.md I just added some build setup docs on how to build this: https://github.com/evmar/retrowin32/blob/main/doc/build_setup.md...
Oh yeah, swap_remove makes sense to me! I wonder if there's some way you can swap_remove the current CPU such that we don't even need the ::Free state, but I...
FYI I dropped CPUStatus::Exit here https://github.com/evmar/retrowin32/commit/c1735a7dba8374dacc04d448ccd6a73dce1832ec
This looks good, I merged it with another commit on top! We can refine the cleanup bits later, I don't imagine there are too many threads starting/exiting in the programs...
Now that I look back on this, it's unclear that pocoman even needs these (?)